Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 기록 생성 시, 수영장 정보를 쿠키에 저장하는 로직 구현 #454

Merged
merged 6 commits into from
Nov 17, 2024

Conversation

wokbjso
Copy link
Member

@wokbjso wokbjso commented Nov 10, 2024

🤔 어떤 문제가 발생했나요?

  • 가장 최근에 생성한 기록의 수영장 정보를, 이후의 기록에서 불러와야 했습니다.

🎉 어떻게 해결했나요?

  • 보안성을 필요로하는 데이터가 아니여서 로컬 스토리지를 고려했지만, 웹앱에서의 동작도 고려하여 쿠키를 사용하여 해결했습니다.

📷 이미지 첨부 (Option)

  • NA

⚠️ 유의할 점! (Option)

  • NA

@king2dwellsang king2dwellsang added Review Plz🙏 # Review is not yet complete feat # Add feature labels Nov 10, 2024
Copy link
Collaborator

@summermong summermong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@king2dwellsang king2dwellsang added Approved 🆗 # Review is completed and removed Review Plz🙏 # Review is not yet complete labels Nov 17, 2024
@wokbjso wokbjso merged commit 5aca626 into main Nov 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved 🆗 # Review is completed feat # Add feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants